Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for perl based on location of Ska Python #347

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

taldcroft
Copy link
Member

Description

This is basically what is used for the sandbox starcheck, and it appears to work fine.

Testing

  • [N/A] Passes unit tests
  • Functional testing (partial)

Minimal testing

I installed this into a ska3-shiny environment on Mac and confirmed that it ran without error on a representative recent set of load products.

@jeanconn
Copy link
Contributor

jeanconn commented Jul 1, 2020

Still would need testing on ska3-flight to go in master but besides that fine (I suppose this would technically need a not /proj/sot/ska3/flight root test environment).

@jeanconn
Copy link
Contributor

jeanconn commented Jul 1, 2020

This looks to work for me in a root linux test ska. The only perfect testing issue is that is still a bit different from the call to /proj/sot/ska/bin/starcheck that calls /proj/sot/ska3/flight/bin/starcheck. I'm good with the change.

@taldcroft
Copy link
Member Author

Should we put this into a shiny branch to punt off needing to test twice (in current ska3-flight and shiny?). That's kind of the way I've been going with changes like this.

@jeanconn
Copy link
Contributor

jeanconn commented Jul 1, 2020

For the launcher, I've already done the integration testing that is required for master promotion, so this can just go in master now. Because of the nature of the launcher, I still note that this is a change that should be checked after promotion (as in, this kind of change should get a "SOT MP should run this after promotion" test). No big deal. I would like to get a few more changes in for starcheck soon and haven't thought of anything that really needs a shiny branch.

@taldcroft taldcroft merged commit a519f0b into master Jul 8, 2020
@taldcroft taldcroft deleted the standalone-launcher branch July 8, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants